3289 harvest via oai pmh of rein d space fails#3321
Merged
Conversation
added 30 commits
July 1, 2026 12:21
…pes of exceptions caught
added 2 commits
July 2, 2026 12:08
rscipien
reviewed
Jul 3, 2026
| if(this.protocol == null || this.authority == null || this.identifier == null) { | ||
| return ""; | ||
| } else if(HTTP_PROTOCOL.equals(this.protocol) || HTTPS_PROTOCOL.equals(this.protocol)) { | ||
| return this.protocol + ':' + this.protocol + "://" + this.authority + this.identifier; |
Contributor
There was a problem hiding this comment.
Two time this.protocol this was intended?
Contributor
Author
There was a problem hiding this comment.
yes - we have the following global id types: "doi", "hdl" "http" and "https"
in case of doi the string representation shall be
doi:blabla
in case of hdl the string represenation shall be
hdl:blablabla
so in case of http the string representation shall be
http:http://blablabalaba
ans in case of https the string respresentation shall be
htttps:https://blablabla
rscipien
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.